chrome/browser/ui/webui/settings_utils_unittest.cc - Issue 1841083005: Options: disallow bad URLs from being entered as startup pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/settings_utils_unittest.cc

Issue 1841083005: Options: disallow bad URLs from being entered as startup pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup-browser-proxy

Patch Set: fixes Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/webui/settings_utils.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 namespace settings_utils {

	10

	11 TEST(SettingsUtilsTest, FixupAndValidateStartupPage) {

	12 EXPECT_FALSE(FixupAndValidateStartupPage(std::string(), nullptr));

	13 EXPECT_FALSE(FixupAndValidateStartupPage(" ", nullptr));

	14 EXPECT_FALSE(FixupAndValidateStartupPage("^&*@)^)", nullptr));

	15 EXPECT_FALSE(FixupAndValidateStartupPage("chrome://quit", nullptr));

	16

	17 EXPECT_TRUE(FixupAndValidateStartupPage("facebook.com", nullptr));

	18 EXPECT_TRUE(FixupAndValidateStartupPage("http://reddit.com", nullptr));

	19 EXPECT_TRUE(FixupAndValidateStartupPage("https://google.com", nullptr));

	20 EXPECT_TRUE(FixupAndValidateStartupPage("chrome://apps", nullptr));
	dpapad 2016/03/31 20:34:08 Can we add one case where the 2nd parameter is use Can we add one case where the 2nd parameter is used and inspect that the fixed URL is as expected? Dan Beam 2016/03/31 22:04:40 Done. Show quoted text On 2016/03/31 20:34:08, dpapad wrote: > Can we add one case where the 2nd parameter is used and inspect that the fixed > URL is as expected? Done.
	21 }

	22

	23 } // namespace settings_utils

OLD	NEW

« chrome/browser/ui/webui/settings_utils.cc ('K') | « chrome/browser/ui/webui/settings_utils.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »