Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1840113002: Reland of Include isolate.py in data for Android unit tests (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Include isolate.py in data for Android unit tests Now with check disabled for non-android checkouts. This is required for any test that uses an .isolate to push files to the device (e.g. base_unittests). BUG=589318 Committed: https://crrev.com/4b6084284590609810fb2c0653fd1b42c6fcaddb Cr-Commit-Position: refs/heads/master@{#384039}

Patch Set 1 #

Patch Set 2 : disable check for non-android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -29 lines) Patch
M PRESUBMIT.py View 1 3 chunks +114 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 chunks +97 lines, -4 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/BUILD.gn View 1 1 chunk +17 lines, -22 lines 0 comments Download
A build/android/test_runner.pydeps View 1 chunk +153 lines, -0 lines 0 comments Download
A build/print_python_deps.py View 1 chunk +70 lines, -0 lines 0 comments Download
A build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A build/secondary/tools/swarming_client/isolate.pydeps View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
agrieve
Created Reland of Include isolate.py in data for Android unit tests
4 years, 8 months ago (2016-03-29 16:15:26 UTC) #1
agrieve
On 2016/03/29 16:15:26, agrieve wrote: > Created Reland of Include isolate.py in data for Android ...
4 years, 8 months ago (2016-03-29 18:03:13 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-30 16:29:56 UTC) #4
jbudorick
build/ lgtm
4 years, 8 months ago (2016-03-30 16:33:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840113002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840113002/200001
4 years, 8 months ago (2016-03-30 17:52:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 8 months ago (2016-03-30 18:50:32 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4b6084284590609810fb2c0653fd1b42c6fcaddb Cr-Commit-Position: refs/heads/master@{#384039}
4 years, 8 months ago (2016-03-30 18:52:21 UTC) #11
Sergiy Byelozyorov
4 years, 8 months ago (2016-04-01 10:43:24 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:200001) has been created in
https://codereview.chromium.org/1851773002/ by sergiyb@chromium.org.

The reason for reverting is: Speculative revert, see http://crbug.com/599692..

Powered by Google App Engine
This is Rietveld 408576698