Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1851773002: Revert of Include isolate.py in data for Android unit tests (Closed)

Created:
4 years, 8 months ago by Sergiy Byelozyorov
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include isolate.py in data for Android unit tests (patchset #2 id:200001 of https://codereview.chromium.org/1840113002/ ) Reason for revert: Speculative revert, see http://crbug.com/599692. Original issue's description: > Reland of Include isolate.py in data for Android unit tests > > Now with check disabled for non-android checkouts. > > This is required for any test that uses an .isolate to push files to the > device (e.g. base_unittests). > > BUG=589318 > > Committed: https://crrev.com/4b6084284590609810fb2c0653fd1b42c6fcaddb > Cr-Commit-Position: refs/heads/master@{#384039} TBR=jochen@chromium.org,jbudorick@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589318, 599692 Committed: https://crrev.com/b4f617bded338ef36d034ca9dd5e94e2567b54ca Cr-Commit-Position: refs/heads/master@{#384557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -587 lines) Patch
M PRESUBMIT.py View 3 chunks +0 lines, -114 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +4 lines, -97 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 2 chunks +3 lines, -4 lines 0 comments Download
M build/android/BUILD.gn View 1 chunk +22 lines, -17 lines 0 comments Download
D build/android/test_runner.pydeps View 1 chunk +0 lines, -153 lines 0 comments Download
D build/print_python_deps.py View 1 chunk +0 lines, -70 lines 0 comments Download
D build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D build/secondary/tools/swarming_client/isolate.pydeps View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sergiy Byelozyorov
Created Revert of Include isolate.py in data for Android unit tests
4 years, 8 months ago (2016-04-01 10:43:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851773002/1
4 years, 8 months ago (2016-04-01 10:43:40 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/163444)
4 years, 8 months ago (2016-04-01 10:52:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851773002/1
4 years, 8 months ago (2016-04-01 11:48:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 12:02:16 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b4f617bded338ef36d034ca9dd5e94e2567b54ca Cr-Commit-Position: refs/heads/master@{#384557}
4 years, 8 months ago (2016-04-01 12:03:54 UTC) #14
agrieve
4 years, 8 months ago (2016-04-01 14:56:05 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1846103005/ by agrieve@chromium.org.

The reason for reverting is: going to fix....

Powered by Google App Engine
This is Rietveld 408576698