Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1839103002: Revert of Include isolate.py in data for Android unit tests (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include isolate.py in data for Android unit tests (patchset #5 id:80001 of https://codereview.chromium.org/1784373002/ ) Reason for revert: PRESUBMIT isn't working for non-android checkouts, as shown by: https://codereview.chromium.org/1840913002/diff/1/build/android/test_runner.pydeps#oldcode138 Original issue's description: > Include isolate.py in data for Android unit tests > > This is required for any test that uses an .isolate to push files to the > device (e.g. base_unittests). > > BUG=589318 > > Committed: https://crrev.com/9e299ea6bbf87415d64d9d84003162d71304ccb9 > Cr-Commit-Position: refs/heads/master@{#383127} TBR=jochen@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589318 Committed: https://crrev.com/e33676c3fafbf203fed00d4213cc442f0cc617e2 Cr-Commit-Position: refs/heads/master@{#383733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -577 lines) Patch
M PRESUBMIT.py View 3 chunks +0 lines, -105 lines 0 comments Download
M PRESUBMIT_test.py View 2 chunks +4 lines, -96 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 2 chunks +3 lines, -4 lines 0 comments Download
M build/android/BUILD.gn View 1 chunk +22 lines, -17 lines 0 comments Download
D build/android/test_runner.pydeps View 1 chunk +0 lines, -153 lines 0 comments Download
D build/print_python_deps.py View 1 chunk +0 lines, -70 lines 0 comments Download
D build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D build/secondary/tools/swarming_client/isolate.pydeps View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
agrieve
Created Revert of Include isolate.py in data for Android unit tests
4 years, 8 months ago (2016-03-29 15:08:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839103002/1
4 years, 8 months ago (2016-03-29 15:09:12 UTC) #2
agrieve
On 2016/03/29 15:09:12, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 8 months ago (2016-03-29 15:12:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839103002/1
4 years, 8 months ago (2016-03-29 15:31:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 15:47:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e33676c3fafbf203fed00d4213cc442f0cc617e2 Cr-Commit-Position: refs/heads/master@{#383733}
4 years, 8 months ago (2016-03-29 15:48:35 UTC) #8
agrieve
4 years, 8 months ago (2016-03-29 16:15:25 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1840113002/ by agrieve@chromium.org.

The reason for reverting is: to be fixed.

Powered by Google App Engine
This is Rietveld 408576698