Moving remaining mocks from WebTestProxyBase into TestRunner.

Moving remaining mocks from WebTestProxyBase into TestRunner.

This CL moves SpellCheckClient and MockCredentialManagerClient
from WebTestProxyBase into TestRunner.  This keeps the mocks
closer to the actual usage and helps further limit the amount
of code left inside WebTestProxyBase (most of the code has been
moved out into WebFrameTestClient and WebViewTestClient in the
few previous CLs).

This CL also makes WebTestRunner responsible for installing mocks
it manages into a particular WebView (i.e. this CL moves this
code out of LayoutTestContentRendererClient::RenderViewCreated
and into WebTestRunner::InitializeWebViewWithMocks).

Note that the removed WebTestProxyBase::PostSpellCheckEvent method
didn't disappear altogether, but was instead inlined into
SpellCheckClient::FinishLastTextCheck.

BUG=595089
Committed: https://crrev.com/5c2279cfe031d3fe92687e7e83f13feeafb407c0
Cr-Commit-Position: refs/heads/master@{#385194}

[Łukasz Anforowicz, 2016-03-30 21:24:32]

Description was changed from

==========
Moving remaining mocks from WebTestProxyBase into TestRunner.

This CL moves SpellCheckClient and MockCredentialManagerClient
from WebTestProxyBase into TestRunner.  This keeps the mocks
closer to the actual usage and helps further limit the amount
of code left inside WebTestProxyBase (most of the code has been
moved out into WebFrameTestClient and WebViewTestClient in the
few previous CLs).

BUG=595089
==========

to

==========
Moving remaining mocks from WebTestProxyBase into TestRunner.

This CL moves SpellCheckClient and MockCredentialManagerClient
from WebTestProxyBase into TestRunner.  This keeps the mocks
closer to the actual usage and helps further limit the amount
of code left inside WebTestProxyBase (most of the code has been
moved out into WebFrameTestClient and WebViewTestClient in the
few previous CLs).

This CL also makes WebTestRunner responsible for installing mocks
it manages into a particular WebView (i.e. this CL moves this
code out of LayoutTestContentRendererClient::RenderViewCreated
and into WebTestRunner::InitializeWebViewWithMocks).

Note that the removed WebTestProxyBase::PostSpellCheckEvent method
didn't disappear altogether, but was instead inlined into
SpellCheckClient::FinishLastTextCheck.

BUG=595089
==========

[Łukasz Anforowicz, 2016-03-30 22:51:09]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-30 22:51:10]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-03-31 15:14:41]

lgtm

[Łukasz Anforowicz, 2016-04-05 04:24:39]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 04:25:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839853002/60001

[commit-bot: I haz the power, 2016-04-05 04:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 04:35:10]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-04-05 16:39:23]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-05 16:39:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1839853002/#ps60001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-04-05 16:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839853002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839853002/60001

[commit-bot: I haz the power, 2016-04-05 16:44:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-05 16:46:23]

Description was changed from

==========
Moving remaining mocks from WebTestProxyBase into TestRunner.

This CL moves SpellCheckClient and MockCredentialManagerClient
from WebTestProxyBase into TestRunner.  This keeps the mocks
closer to the actual usage and helps further limit the amount
of code left inside WebTestProxyBase (most of the code has been
moved out into WebFrameTestClient and WebViewTestClient in the
few previous CLs).

This CL also makes WebTestRunner responsible for installing mocks
it manages into a particular WebView (i.e. this CL moves this
code out of LayoutTestContentRendererClient::RenderViewCreated
and into WebTestRunner::InitializeWebViewWithMocks).

Note that the removed WebTestProxyBase::PostSpellCheckEvent method
didn't disappear altogether, but was instead inlined into
SpellCheckClient::FinishLastTextCheck.

BUG=595089
==========

to

==========
Moving remaining mocks from WebTestProxyBase into TestRunner.

This CL moves SpellCheckClient and MockCredentialManagerClient
from WebTestProxyBase into TestRunner.  This keeps the mocks
closer to the actual usage and helps further limit the amount
of code left inside WebTestProxyBase (most of the code has been
moved out into WebFrameTestClient and WebViewTestClient in the
few previous CLs).

This CL also makes WebTestRunner responsible for installing mocks
it manages into a particular WebView (i.e. this CL moves this
code out of LayoutTestContentRendererClient::RenderViewCreated
and into WebTestRunner::InitializeWebViewWithMocks).

Note that the removed WebTestProxyBase::PostSpellCheckEvent method
didn't disappear altogether, but was instead inlined into
SpellCheckClient::FinishLastTextCheck.

BUG=595089

Committed: https://crrev.com/5c2279cfe031d3fe92687e7e83f13feeafb407c0
Cr-Commit-Position: refs/heads/master@{#385194}
==========

[commit-bot: I haz the power, 2016-04-05 16:46:24]

Patchset 4 (id:??) landed as
https://crrev.com/5c2279cfe031d3fe92687e7e83f13feeafb407c0
Cr-Commit-Position: refs/heads/master@{#385194}