Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: components/test_runner/spell_check_client.cc

Issue 1839853002: Moving remaining mocks from WebTestProxyBase into TestRunner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@splitting-web-view-test-client
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/spell_check_client.h ('k') | components/test_runner/test_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/spell_check_client.cc
diff --git a/components/test_runner/spell_check_client.cc b/components/test_runner/spell_check_client.cc
index 304cfed6b6d8dee95a2580b526993b97a61f7bda..32bfd880b33219e9f5a01e355b52a689172e890c 100644
--- a/components/test_runner/spell_check_client.cc
+++ b/components/test_runner/spell_check_client.cc
@@ -6,10 +6,11 @@
#include <stddef.h>
+#include "base/logging.h"
#include "base/macros.h"
#include "components/test_runner/mock_grammar_check.h"
+#include "components/test_runner/test_runner.h"
#include "components/test_runner/web_test_delegate.h"
-#include "components/test_runner/web_test_proxy.h"
#include "third_party/WebKit/public/web/WebTextCheckingCompletion.h"
#include "third_party/WebKit/public/web/WebTextCheckingResult.h"
@@ -35,9 +36,10 @@ class HostMethodTask : public WebMethodTask<SpellCheckClient> {
} // namespace
-SpellCheckClient::SpellCheckClient(WebTestProxyBase* web_test_proxy)
- : last_requested_text_checking_completion_(0),
- web_test_proxy_(web_test_proxy) {
+SpellCheckClient::SpellCheckClient(TestRunner* test_runner)
+ : last_requested_text_checking_completion_(nullptr),
+ test_runner_(test_runner) {
+ DCHECK(test_runner);
}
SpellCheckClient::~SpellCheckClient() {
@@ -140,7 +142,8 @@ void SpellCheckClient::FinishLastTextCheck() {
last_requested_text_checking_completion_->didFinishCheckingText(results);
last_requested_text_checking_completion_ = 0;
- web_test_proxy_->PostSpellCheckEvent(blink::WebString("FinishLastTextCheck"));
+ if (test_runner_->shouldDumpSpellCheckCallbacks())
+ delegate_->PrintMessage("SpellCheckEvent: FinishLastTextCheck\n");
}
} // namespace test_runner
« no previous file with comments | « components/test_runner/spell_check_client.h ('k') | components/test_runner/test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698