Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 881f8a6cdca7e919a6e2e4a24d4de3fa5b5a6bd8..5a31bc575bdc6321a33ca2797627a7bab7da0741 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -659,7 +659,7 @@ void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na
{
if (!m_webFrame->client())
return;
- ASSERT(m_webFrame->frame()->document());
+ DCHECK(m_webFrame->frame()->document());
Fullscreen::fullyExitFullscreen(*m_webFrame->frame()->document());
m_webFrame->client()->loadURLExternally(
WrappedResourceRequest(request), static_cast<WebNavigationPolicy>(policy), suggestedName, shouldReplaceCurrentEntry);
@@ -671,7 +671,7 @@ bool FrameLoaderClientImpl::navigateBackForward(int offset) const
if (!webview->client())
return false;
- ASSERT(offset);
+ DCHECK(offset);
if (offset > webview->client()->historyForwardListCount())
return false;
if (offset < -webview->client()->historyBackListCount())
@@ -932,7 +932,7 @@ void FrameLoaderClientImpl::didUpdateToUniqueOrigin()
{
if (!m_webFrame->client())
return;
- ASSERT(m_webFrame->getSecurityOrigin().isUnique());
+ DCHECK(m_webFrame->getSecurityOrigin().isUnique());
m_webFrame->client()->didUpdateToUniqueOrigin(m_webFrame->getSecurityOrigin().isPotentiallyTrustworthy());
}
« no previous file with comments | « third_party/WebKit/Source/web/FindInPageCoordinates.cpp ('k') | third_party/WebKit/Source/web/FullscreenController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698