Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 void FrameLoaderClientImpl::didStopLoading() 652 void FrameLoaderClientImpl::didStopLoading()
653 { 653 {
654 if (m_webFrame->client()) 654 if (m_webFrame->client())
655 m_webFrame->client()->didStopLoading(); 655 m_webFrame->client()->didStopLoading();
656 } 656 }
657 657
658 void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na vigationPolicy policy, const String& suggestedName, bool shouldReplaceCurrentEnt ry) 658 void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, Na vigationPolicy policy, const String& suggestedName, bool shouldReplaceCurrentEnt ry)
659 { 659 {
660 if (!m_webFrame->client()) 660 if (!m_webFrame->client())
661 return; 661 return;
662 ASSERT(m_webFrame->frame()->document()); 662 DCHECK(m_webFrame->frame()->document());
663 Fullscreen::fullyExitFullscreen(*m_webFrame->frame()->document()); 663 Fullscreen::fullyExitFullscreen(*m_webFrame->frame()->document());
664 m_webFrame->client()->loadURLExternally( 664 m_webFrame->client()->loadURLExternally(
665 WrappedResourceRequest(request), static_cast<WebNavigationPolicy>(policy ), suggestedName, shouldReplaceCurrentEntry); 665 WrappedResourceRequest(request), static_cast<WebNavigationPolicy>(policy ), suggestedName, shouldReplaceCurrentEntry);
666 } 666 }
667 667
668 bool FrameLoaderClientImpl::navigateBackForward(int offset) const 668 bool FrameLoaderClientImpl::navigateBackForward(int offset) const
669 { 669 {
670 WebViewImpl* webview = m_webFrame->viewImpl(); 670 WebViewImpl* webview = m_webFrame->viewImpl();
671 if (!webview->client()) 671 if (!webview->client())
672 return false; 672 return false;
673 673
674 ASSERT(offset); 674 DCHECK(offset);
675 if (offset > webview->client()->historyForwardListCount()) 675 if (offset > webview->client()->historyForwardListCount())
676 return false; 676 return false;
677 if (offset < -webview->client()->historyBackListCount()) 677 if (offset < -webview->client()->historyBackListCount())
678 return false; 678 return false;
679 webview->client()->navigateBackForwardSoon(offset); 679 webview->client()->navigateBackForwardSoon(offset);
680 return true; 680 return true;
681 } 681 }
682 682
683 void FrameLoaderClientImpl::didAccessInitialDocument() 683 void FrameLoaderClientImpl::didAccessInitialDocument()
684 { 684 {
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 { 925 {
926 if (!m_webFrame->client()) 926 if (!m_webFrame->client())
927 return; 927 return;
928 m_webFrame->client()->didEnforceStrictMixedContentChecking(); 928 m_webFrame->client()->didEnforceStrictMixedContentChecking();
929 } 929 }
930 930
931 void FrameLoaderClientImpl::didUpdateToUniqueOrigin() 931 void FrameLoaderClientImpl::didUpdateToUniqueOrigin()
932 { 932 {
933 if (!m_webFrame->client()) 933 if (!m_webFrame->client())
934 return; 934 return;
935 ASSERT(m_webFrame->getSecurityOrigin().isUnique()); 935 DCHECK(m_webFrame->getSecurityOrigin().isUnique());
936 m_webFrame->client()->didUpdateToUniqueOrigin(m_webFrame->getSecurityOrigin( ).isPotentiallyTrustworthy()); 936 m_webFrame->client()->didUpdateToUniqueOrigin(m_webFrame->getSecurityOrigin( ).isPotentiallyTrustworthy());
937 } 937 }
938 938
939 void FrameLoaderClientImpl::didChangeSandboxFlags(Frame* childFrame, SandboxFlag s flags) 939 void FrameLoaderClientImpl::didChangeSandboxFlags(Frame* childFrame, SandboxFlag s flags)
940 { 940 {
941 if (!m_webFrame->client()) 941 if (!m_webFrame->client())
942 return; 942 return;
943 m_webFrame->client()->didChangeSandboxFlags(WebFrame::fromFrame(childFrame), static_cast<WebSandboxFlags>(flags)); 943 m_webFrame->client()->didChangeSandboxFlags(WebFrame::fromFrame(childFrame), static_cast<WebSandboxFlags>(flags));
944 } 944 }
945 945
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 return nullptr; 1057 return nullptr;
1058 return m_webFrame->client()->frameBlameContext(); 1058 return m_webFrame->client()->frameBlameContext();
1059 } 1059 }
1060 1060
1061 RawPtr<LinkResource> FrameLoaderClientImpl::createServiceWorkerLinkResource(HTML LinkElement* owner) 1061 RawPtr<LinkResource> FrameLoaderClientImpl::createServiceWorkerLinkResource(HTML LinkElement* owner)
1062 { 1062 {
1063 return ServiceWorkerLinkResource::create(owner); 1063 return ServiceWorkerLinkResource::create(owner);
1064 } 1064 }
1065 1065
1066 } // namespace blink 1066 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/FindInPageCoordinates.cpp ('k') | third_party/WebKit/Source/web/FullscreenController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698