Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FullscreenController.cpp
diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp
index 11b1ac3f7e6119395d987c5c1ab417eb5db19adb..19b19ee2e849bf07a59307ad2e4233441e65f0c7 100644
--- a/third_party/WebKit/Source/web/FullscreenController.cpp
+++ b/third_party/WebKit/Source/web/FullscreenController.cpp
@@ -79,7 +79,7 @@ void FullscreenController::didEnterFullScreen()
}
Fullscreen::from(document).didEnterFullScreenForElement(element.get());
- ASSERT(Fullscreen::currentFullScreenElementFrom(document) == element);
+ DCHECK_EQ(Fullscreen::currentFullScreenElementFrom(document), element);
if (isHTMLVideoElement(element)) {
HTMLVideoElement* videoElement = toHTMLVideoElement(element);
@@ -157,7 +157,7 @@ void FullscreenController::enterFullScreenForElement(Element* element)
void FullscreenController::exitFullScreenForElement(Element* element)
{
- ASSERT(element);
+ DCHECK(element);
// The client is exiting full screen, so don't send a notification.
if (m_isCancelingFullScreen)
« no previous file with comments | « third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp ('k') | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698