third_party/WebKit/Source/web/FindInPageCoordinates.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FindInPageCoordinates.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/FindInPageCoordinates.cpp

diff --git a/third_party/WebKit/Source/web/FindInPageCoordinates.cpp b/third_party/WebKit/Source/web/FindInPageCoordinates.cpp

index 86186c98dabd1f4a03d6e13d981fdebf9314ae39..1e09e7b7699187ecd01a6b2ba1488905c2198557 100644

--- a/third_party/WebKit/Source/web/FindInPageCoordinates.cpp

+++ b/third_party/WebKit/Source/web/FindInPageCoordinates.cpp

@@ -48,7 +48,7 @@ namespace blink {

static const LayoutBlock* enclosingScrollableAncestor(const LayoutObject* layoutObject)

{

- ASSERT(!layoutObject->isLayoutView());

+ DCHECK(!layoutObject->isLayoutView());

// Trace up the containingBlocks until we reach either the layoutObject view or a scrollable object.

const LayoutBlock* container = layoutObject->containingBlock();

@@ -59,9 +59,9 @@ static const LayoutBlock* enclosingScrollableAncestor(const LayoutObject* layout

static FloatRect toNormalizedRect(const FloatRect& absoluteRect, const LayoutObject* layoutObject, const LayoutBlock* container)

{

- ASSERT(layoutObject);

+ DCHECK(layoutObject);

- ASSERT(container || layoutObject->isLayoutView());

+ DCHECK(container || layoutObject->isLayoutView());

if (!container)

return FloatRect();

@@ -117,7 +117,7 @@ FloatRect findInPageRectFromAbsoluteRect(const FloatRect& inputRect, const Layou

layoutObject = container;

}

- ASSERT(layoutObject->isLayoutView());

+ DCHECK(layoutObject->isLayoutView());

// Jump to the layoutObject owning the frame, if any.

layoutObject = layoutObject->frame() ? layoutObject->frame()->ownerLayoutObject() : 0;