Really remove io support when dart:io is unsupported.

Really remove io support when dart:io is unsupported.

Previously we would compile in implementaitions of native calls for
IO functions that would never be used. This CL provides implementations
that throw a Dart exception if they're called by mistake. It also uses
a DART_IO_DISABLED preprocessor define to clean up the build files and
check that we're not including code we shouldn't.

R=iposva@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/7308e58c3ffc1d295ffbf173c68661f2611e86b0

[zra, 2016-03-25 21:40:55]

zra@google.com changed reviewers:
+ iposva@google.com

[zra, 2016-03-25 22:05:40]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[zra, 2016-03-25 22:05:41]

+johnmccutchan for BUILD.gn change

[Ivan Posva, 2016-03-29 00:45:46]

LGTM -ip

[Cutch, 2016-03-29 14:58:56]

lgtm

[zra, 2016-03-29 18:22:07]

Description was changed from

==========
Really remove io support when dart:io is unsupported.

Previously we would compile in implementaitions of native calls for
IO functions that would never be used. This CL provides implementations
that throw a Dart exception if they're called by mistake. It also uses
a DART_IO_DISABLED preprocessor define to clean up the build files and
check that we're not including code we shouldn't.
==========

to

==========
Really remove io support when dart:io is unsupported.

Previously we would compile in implementaitions of native calls for
IO functions that would never be used. This CL provides implementations
that throw a Dart exception if they're called by mistake. It also uses
a DART_IO_DISABLED preprocessor define to clean up the build files and
check that we're not including code we shouldn't.

R=iposva@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7308e58c3ffc1d295ffbf173c68661f2611e86b0
==========

[zra, 2016-03-29 18:22:08]

Committed patchset #3 (id:40001) manually as
7308e58c3ffc1d295ffbf173c68661f2611e86b0 (presubmit successful).

[Bill Hesse, 2016-03-30 09:50:26]

whesse@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-03-30 09:50:27]

https://codereview.chromium.org/1839463002/diff/40001/runtime/bin/socket.h
File runtime/bin/socket.h (right):

https://codereview.chromium.org/1839463002/diff/40001/runtime/bin/socket.h#ne...
runtime/bin/socket.h:8: #if defined(DART_IO_DISABLED)
This error is being hit on Windows compilations of Dartium.
So Dartium is broken since this commit.