runtime/bin/socket.h - Issue 1839463002: Really remove io support when dart:io is unsupported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.h

Issue 1839463002: Really remove io support when dart:io is unsupported. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket.h

diff --git a/runtime/bin/socket.h b/runtime/bin/socket.h

index b058a51c203a7f15f516ef9b4a334161781f94f4..2cf940c54d90669d49b62676a7c0ff02df1f3a28 100644

--- a/runtime/bin/socket.h

+++ b/runtime/bin/socket.h

@@ -5,12 +5,11 @@

#ifndef BIN_SOCKET_H_

#define BIN_SOCKET_H_

-#include <map>

+#if defined(DART_IO_DISABLED)

Bill Hesse 2016/03/30 09:50:27 This error is being hit on Windows compilations of

+#error "socket.h can only be included on builds with IO enabled"

+#endif

#include "platform/globals.h"

-#include "bin/builtin.h"

-#include "bin/dartutils.h"

// Declare the OS-specific types ahead of defining the generic class.

#if defined(TARGET_OS_ANDROID)

#include "bin/socket_android.h"

@@ -23,6 +22,11 @@

#else

#error Unknown target os.

#endif

+#include <map>

+#include "bin/builtin.h"

+#include "bin/dartutils.h"

#include "bin/thread.h"

#include "bin/utils.h"

« no previous file with comments | « runtime/bin/secure_socket_unsupported.cc ('k') | runtime/bin/socket.cc » ('j') | no next file with comments »