Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: runtime/bin/BUILD.gn

Issue 1839463002: Really remove io support when dart:io is unsupported. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/socket.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 7a6c70f2e1a42caeb793e239f6a9722b0e948f7b..04d7097e1f3d69d0e4162ec3bc82177fad0d1e7d 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -191,11 +191,6 @@ executable("gen_snapshot") {
"builtin_gen_snapshot.cc",
"builtin.cc",
"builtin.h",
- "platform_android.cc",
- "platform_linux.cc",
- "platform_macos.cc",
- "platform_win.cc",
- "platform.h",
"vmservice_impl.cc",
"vmservice_impl.h",
# Include generated source files.
@@ -231,27 +226,13 @@ io_impl_sources_gypi =
source_set("gen_snapshot_dart_io") {
configs += ["..:dart_config",]
- # Set custom sources assignment filter. The custom filters does three things:
- # 1) Filters out unnecessary files pulled in from the gypi files.
- # 2) Filters out secure socket support.
- # 3) Enables dart:io by filtering out _unsupported.cc implementations.
+ deps = [
+ "//third_party/zlib",
+ ]
+
custom_sources_filter = [
- "*net/nss_memio.cc",
- "*net/nss_memio.h",
- "*root_certificates.cc",
- "*secure_socket_boringssl.cc",
- "*secure_socket_boringssl.h",
- "*secure_socket_macos.cc",
- "*secure_socket_macos.h",
- "*secure_socket.h",
- "filter.cc",
- "*io_service_unsupported.cc",
- "platform_*.cc",
- "*io_service.cc",
- "*io_service.h",
"*_test.cc",
"*_test.h",
- "*dbg*",
"builtin.cc",
"builtin_common.cc",
"builtin_gen_snapshot.cc",
@@ -271,11 +252,6 @@ source_set("gen_snapshot_dart_io") {
sources += [
"io_natives.cc",
"io_natives.h",
- "log_android.cc",
- "log_linux.cc",
- "log_macos.cc",
- "log_win.cc",
- "log.h",
]
include_dirs = [
@@ -289,26 +265,9 @@ source_set("gen_snapshot_dart_io") {
source_set("embedded_dart_io") {
configs += ["..:dart_config",]
- # Set custom sources assignment filter. The custom filters does three things:
- # 1) Filters out unnecessary files pulled in from the gypi files.
- # 2) Filters out secure socket support.
- # 3) Enables dart:io by filtering out _unsupported.cc implementations.
custom_sources_filter = [
- "*net/nss_memio.cc",
- "*net/nss_memio.h",
- "*root_certificates.cc",
- "*secure_socket_boringssl.cc",
- "*secure_socket_boringssl.h",
- "*secure_socket_macos.cc",
- "*secure_socket_macos.h",
- "*secure_socket.h",
- "*filter_unsupported.cc",
- "*io_service_unsupported.cc",
- "*io_service.cc",
- "*io_service.h",
"*_test.cc",
"*_test.h",
- "*dbg*",
"builtin.cc",
"builtin_gen_snapshot.cc",
]
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/socket.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698