Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1839393002: Add parsing for type aliases (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 8 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@types-1841093002-fun-decl
Target Ref:
refs/pending/heads/experimental/nikolaos/types
Project:
v8
Visibility:
Public.

Description

Add parsing for type aliases This is based on https://codereview.chromium.org/1841093002 R=rossberg@chromium.org BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Total comments: 2

Patch Set 2 : More tests and allow type as an indentifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -0 lines) Patch
M src/parsing/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +31 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/parsing/preparser.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typesystem/type-aliases.js View 1 1 chunk +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
nickie
4 years, 8 months ago (2016-03-30 12:31:56 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1839393002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1839393002/diff/1/test/cctest/test-parsing.cc#newcode7853 test/cctest/test-parsing.cc:7853: "type Err<> = number", How about "type", with ...
4 years, 8 months ago (2016-04-18 09:27:43 UTC) #2
nickie
https://codereview.chromium.org/1839393002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1839393002/diff/1/test/cctest/test-parsing.cc#newcode7853 test/cctest/test-parsing.cc:7853: "type Err<> = number", On 2016/04/18 09:27:43, rossberg wrote: ...
4 years, 8 months ago (2016-04-19 13:52:51 UTC) #3
nickie
4 years, 8 months ago (2016-04-19 14:10:48 UTC) #4
Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
6a143f3ce27309fa0537144e449cbfcfe2bc4dae
https://chromium.googlesource.com/v8/v8/+/6a143f3ce27309fa0537144e449cbfcfe2b...

Powered by Google App Engine
This is Rietveld 408576698