Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1850663002: Add parsing for class declarations (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 8 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@types-1839393002-aliases
Target Ref:
refs/pending/heads/experimental/nikolaos/types
Project:
v8
Visibility:
Public.

Description

Add parsing for class declarations This patch supports: - type parameters, - the "implements" clause, - variable member declarations, and - index members. This is based on https://codereview.chromium.org/1839393002 R=rossberg@chromium.org BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -14 lines) Patch
M src/parsing/parser.cc View 2 chunks +34 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 7 chunks +86 lines, -12 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typesystem/class-declarations.js View 1 chunk +105 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
nickie
4 years, 8 months ago (2016-03-31 10:47:42 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1850663002/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1850663002/diff/1/src/parsing/parser-base.h#newcode1667 src/parsing/parser-base.h:1667: // i.e., class C { [42](x) {} } ...
4 years, 8 months ago (2016-04-18 11:03:08 UTC) #2
nickie
https://codereview.chromium.org/1850663002/diff/1/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1850663002/diff/1/src/parsing/parser-base.h#newcode1667 src/parsing/parser-base.h:1667: // i.e., class C { [42](x) {} } does ...
4 years, 8 months ago (2016-04-19 14:55:30 UTC) #3
nickie
4 years, 8 months ago (2016-04-20 13:55:10 UTC) #4
Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
48fb4065d12bd5df2ee08cb8ce602b4d9cd1bf5d
https://chromium.googlesource.com/v8/v8/+/48fb4065d12bd5df2ee08cb8ce602b4d9cd...

Powered by Google App Engine
This is Rietveld 408576698