Add optional types to function/method declarations

Add optional types to function/method declarations

This is based on https://codereview.chromium.org/1817353007

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true

[rossberg, 2016-04-18 09:22:25]

lgtm

https://codereview.chromium.org/1841093002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1841093002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:4233: // In that case, return a nullptr instead of a
function literal.
May be worth documenting at the funciton declaration that it may return null.

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
File test/mjsunit/harmony/typesystem/method-definitions.js (right):

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/method-definitions.js:55: // Invalid getters.
What about "get x(y?) {}"?

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/method-definitions.js:63: // Invalid setters.
Same here: "set x(y?) {}", is that legal?

[nickie, 2016-04-19 10:58:10]

https://codereview.chromium.org/1841093002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1841093002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:4233: // In that case, return a nullptr instead of a
function literal.
On 2016/04/18 09:22:24, rossberg wrote:
> May be worth documenting at the funciton declaration that it may return null.

Done.

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
File test/mjsunit/harmony/typesystem/method-definitions.js (right):

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/method-definitions.js:55: // Invalid getters.
On 2016/04/18 09:22:24, rossberg wrote:
> What about "get x(y?) {}"?

Done.

https://codereview.chromium.org/1841093002/diff/1/test/mjsunit/harmony/typesy...
test/mjsunit/harmony/typesystem/method-definitions.js:63: // Invalid setters.
On 2016/04/18 09:22:24, rossberg wrote:
> Same here: "set x(y?) {}", is that legal?

It's not legal and unfortunately it passes.  I'm adding a bug fix and some
tests.

Also, according to TS, the parameter to a setter should not have an initializer.
 But this is not consistent with ES6, so we allow initializers here (I'm not
adding tests for that).  Our untyped V8 allows:

d8> class D { set x(a=42) {print(a);} };
class D { set x(a=42) {print(a);} }
d8> var o = new D;
d8> o.x = 17;
17
17
d8> o.x = undefined;
42

[nickie, 2016-04-19 12:31:45]

Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
4ff50639d47b300dab8c1407d46582ab0bc2ec98
https://chromium.googlesource.com/v8/v8/+/4ff50639d47b300dab8c1407d46582ab0bc...

[nickie, 2016-04-19 12:32:01]

Description was changed from

==========
Add optional types to function/method declarations

This is based on https://codereview.chromium.org/1817353007

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
Add optional types to function/method declarations

This is based on https://codereview.chromium.org/1817353007

R=rossberg@chromium.org
BUG=
NOTRY=true
NOPRESUBMIT=true
==========