Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: test/cctest/test-parsing.cc

Issue 1839393002: Add parsing for type aliases (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@types-1841093002-fun-decl
Patch Set: More tests and allow type as an indentifier Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/preparser.cc ('k') | test/mjsunit/harmony/typesystem/type-aliases.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 767393e04bc7843a24c5c572755c4a93ddab77da..4bfa0b8ec6f71d78e959cd72049770b14db12089 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -7837,3 +7837,45 @@ TEST(TypedModeBindingPatterns) {
RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0,
always_flags, arraysize(always_flags));
}
+
+TEST(TypedModeTypeAliases) {
+ const char* untyped_context_data[][2] = {{"", ""}, {NULL, NULL}};
+ const char* typed_context_data[][2] = {{"'use types'; ", ""}, {NULL, NULL}};
+
+ const char* correct_data[] = {
+ "type NumArray = number[]",
+ "type Fun = (x: number) => number",
+ "type Tree<A> = A | Tree<A>[]",
+ NULL
+ };
+
+ const char* error_data[] = {
+ "type Err<> = number",
+ "type Err",
+ "type Err =",
+ "type Err = ()",
+ NULL
+ };
+
+ const char* type_as_identifier_data[] = {
+ "type",
+ "type = number+1",
+ "type(1, 2, 3)",
+ "type\n42",
+ NULL
+ };
+
+ static const ParserFlag always_flags[] = {kAllowTypes};
+ RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0,
+ always_flags, arraysize(always_flags));
+ RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0,
+ always_flags, arraysize(always_flags));
+ RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0,
+ always_flags, arraysize(always_flags));
+ RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0,
+ always_flags, arraysize(always_flags));
+ RunParserSyncTest(untyped_context_data, type_as_identifier_data, kSuccess,
+ NULL, 0, always_flags, arraysize(always_flags));
+ RunParserSyncTest(typed_context_data, type_as_identifier_data, kSuccess,
+ NULL, 0, always_flags, arraysize(always_flags));
+}
« no previous file with comments | « src/parsing/preparser.cc ('k') | test/mjsunit/harmony/typesystem/type-aliases.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698