Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 183893023: Unify edge type enums across GrEffect subclasses that clip rendering to a geometry. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Unify edge type enums across GrEffect subclasses that clip rendering to a geometry. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13674

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update #

Patch Set 4 : rebase to tot #

Patch Set 5 : fix warnings #

Patch Set 6 : tot again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -231 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M gm/beziereffects.cpp View 6 chunks +49 lines, -27 lines 0 comments Download
M gm/convexpolyeffect.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M gm/rrects.cpp View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 2 2 chunks +51 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 10 chunks +79 lines, -83 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 3 4 18 chunks +42 lines, -21 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 5 chunks +10 lines, -19 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 12 chunks +41 lines, -33 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.h View 1 2 3 1 chunk +2 lines, -10 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 3 10 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-04 20:47:33 UTC) #1
robertphillips
lgtm
6 years, 9 months ago (2014-03-04 20:59:32 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-05 15:03:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/183893023/40001
6 years, 9 months ago (2014-03-05 15:03:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 15:03:33 UTC) #5
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-05 15:03:33 UTC) #6
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-05 15:13:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/183893023/60001
6 years, 9 months ago (2014-03-05 15:13:59 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 15:22:59 UTC) #9
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildGm, BuildSkiaLib, BuildTests, BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=188
6 years, 9 months ago (2014-03-05 15:23:00 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-05 16:47:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/183893023/80001
6 years, 9 months ago (2014-03-05 16:47:46 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 16:47:49 UTC) #13
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-05 16:47:50 UTC) #14
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-05 18:11:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/183893023/100001
6 years, 9 months ago (2014-03-05 18:12:12 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 18:27:56 UTC) #17
Message was sent while issue was closed.
Change committed as 13674

Powered by Google App Engine
This is Rietveld 408576698