Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 186643003: Apply the CTM to the offset in the slow SkOffsetImageFilter path. (Closed)

Created:
6 years, 9 months ago by Stephen White
Modified:
6 years, 9 months ago
Reviewers:
sugoi1, sugoi
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Apply the CTM to the offset in the slow SkOffsetImageFilter path. This was being done in the fast path, but not the slow path. Since I had to rebaseline the offsetimagefilter GM anyway (to accomodate the new test case), I added a red border around the intersection of the (transformed) crop rect and clip rect in each sample, beyond which no pixels should be drawn. Chrome bug: https://code.google.com/p/chromium/issues/detail?id=346362 BUG=skia: R=sugoi@google.com Committed: https://code.google.com/p/skia/source/detail?r=13656

Patch Set 1 #

Patch Set 2 : Add test suppression #

Total comments: 1

Patch Set 3 : SK_Scalar1 is my friend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -14 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gm/offsetimagefilter.cpp View 1 2 4 chunks +27 lines, -13 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Stephen White
sugoi@: PTAL. Thanks!
6 years, 9 months ago (2014-03-04 18:51:32 UTC) #1
sugoi
LGTM with nit: https://codereview.chromium.org/186643003/diff/20001/gm/offsetimagefilter.cpp File gm/offsetimagefilter.cpp (right): https://codereview.chromium.org/186643003/diff/20001/gm/offsetimagefilter.cpp#newcode110 gm/offsetimagefilter.cpp:110: drawClippedBitmap(canvas, *bitmap, paint, SkIntToScalar(1), cropRect); SK_Scalar1 ...
6 years, 9 months ago (2014-03-04 18:56:28 UTC) #2
Stephen White
On 2014/03/04 18:56:28, sugoi wrote: > LGTM with nit: > > https://codereview.chromium.org/186643003/diff/20001/gm/offsetimagefilter.cpp > File gm/offsetimagefilter.cpp ...
6 years, 9 months ago (2014-03-04 19:05:00 UTC) #3
Stephen White
6 years, 9 months ago (2014-03-04 19:05:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r13656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698