appengine/logdog/coordinator/endpoints/logs/get.go - Issue 1838803002: LogDog: BigTable batching schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/logdog/coordinator/endpoints/logs/get.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split

Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/logdog/coordinator/endpoints/logs/get.go

diff --git a/appengine/logdog/coordinator/endpoints/logs/get.go b/appengine/logdog/coordinator/endpoints/logs/get.go

index 3491db7da5674110ec588ce01f80e3f8e26afc39..1692529c9af09b1e965021e20f206448917bb02b 100644

--- a/appengine/logdog/coordinator/endpoints/logs/get.go

+++ b/appengine/logdog/coordinator/endpoints/logs/get.go

@@ -233,7 +233,7 @@ func getHead(c context.Context, req *logdog.GetRequest, st storage.Storage, p ty

err := retry.Retry(c, retry.TransientOnly(retry.Default), func() error {

// Issue the Get request. This may return a transient error, in which case

// we will retry.

- return st.Get(&sreq, func(idx types.MessageIndex, ld []byte) bool {

+ return st.Get(sreq, func(idx types.MessageIndex, ld []byte) bool {

if count > 0 && byteLimit-len(ld) < 0 {

// Not the first log, and we've exceeded our byte limit.

return false