LogDog: BigTable batching schema.

appengine/logdog/coordinator/endpoints/logs/get.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package logs
 
 import (
         "net/url"
         "time"
 
@@ skipping 215 matching lines @@
         sreq := storage.GetRequest{
                 Path:  p,
                 Index: types.MessageIndex(req.Index),
                 Limit: logCount,
         }
 
         count := 0
         err := retry.Retry(c, retry.TransientOnly(retry.Default), func() error {
                 // Issue the Get request. This may return a transient error, in which case
                 // we will retry.
-                return st.Get(&sreq, func(idx types.MessageIndex, ld []byte) bool {
+                return st.Get(sreq, func(idx types.MessageIndex, ld []byte) bool {
                         if count > 0 && byteLimit-len(ld) < 0 {
                                 // Not the first log, and we've exceeded our byte limit.
                                 return false
                         }
                         byteLimit -= len(ld)
 
                         if !(req.NonContiguous || idx == sreq.Index) {
                                 return false
                         }
                         logs = append(logs, ld)
@@ skipping 33 matching lines @@
                         log.ErrorKey: err,
                         "delay":      delay,
                 }.Warningf(c, "Transient error while fetching tail log; retrying.")
         })
         if err != nil {
                 log.WithError(err).Errorf(c, "Failed to fetch tail log.")
                 return nil, err
         }
         return [][]byte{data}, err
 }