Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Unified Diff: appengine/logdog/coordinator/endpoints/logs/get_test.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split
Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/logdog/coordinator/endpoints/logs/get.go ('k') | common/gcloud/pubsub/subscriber/source.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/logdog/coordinator/endpoints/logs/get_test.go
diff --git a/appengine/logdog/coordinator/endpoints/logs/get_test.go b/appengine/logdog/coordinator/endpoints/logs/get_test.go
index 83956923c67bc7d202ee3462cd01754a2663d65f..657f568d945fdb0443dc14f69db3222b3f22e485 100644
--- a/appengine/logdog/coordinator/endpoints/logs/get_test.go
+++ b/appengine/logdog/coordinator/endpoints/logs/get_test.go
@@ -255,10 +255,10 @@ func TestGet(t *testing.T) {
if !v {
// Add the logs to the in-memory temporary storage.
for _, le := range entries {
- err := ms.Put(&storage.PutRequest{
- Path: ls.Path(),
- Index: types.MessageIndex(le.StreamIndex),
- Value: protobufs[le.StreamIndex],
+ err := ms.Put(storage.PutRequest{
+ Path: ls.Path(),
+ Index: types.MessageIndex(le.StreamIndex),
+ Values: [][]byte{protobufs[le.StreamIndex]},
})
if err != nil {
panic(fmt.Errorf("failed to Put() LogEntry: %v", err))
@@ -441,10 +441,10 @@ func TestGet(t *testing.T) {
} else {
// Add corrupted entry to Storage. Create a new entry here, since
// the storage will reject a duplicate/overwrite.
- err := ms.Put(&storage.PutRequest{
- Path: types.StreamPath(req.Path),
- Index: 666,
- Value: []byte{0x00}, // Invalid protobuf, zero tag.
+ err := ms.Put(storage.PutRequest{
+ Path: types.StreamPath(req.Path),
+ Index: 666,
+ Values: [][]byte{{0x00}}, // Invalid protobuf, zero tag.
})
if err != nil {
panic(err)
« no previous file with comments | « appengine/logdog/coordinator/endpoints/logs/get.go ('k') | common/gcloud/pubsub/subscriber/source.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698