Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: appengine/logdog/coordinator/config/bigTable.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split
Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/logdog/coordinator/endpoints/logs/get.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/logdog/coordinator/config/bigTable.go
diff --git a/appengine/logdog/coordinator/config/bigTable.go b/appengine/logdog/coordinator/config/bigTable.go
index 97045d143db95850e10a840c43897edeea40c63a..811e171abc41926a5d055a5174ac66843eafd0f6 100644
--- a/appengine/logdog/coordinator/config/bigTable.go
+++ b/appengine/logdog/coordinator/config/bigTable.go
@@ -79,7 +79,7 @@ func GetStorage(c context.Context) (storage.Storage, error) {
// calls.
c = metadata.NewContext(c, nil)
- return bigtable.New(c, bigtable.Options{
+ st, err := bigtable.New(c, bigtable.Options{
Project: bt.Project,
Zone: bt.Zone,
Cluster: bt.Cluster,
@@ -87,5 +87,10 @@ func GetStorage(c context.Context) (storage.Storage, error) {
ClientOptions: []cloud.ClientOption{
cloud.WithTokenSource(a.TokenSource()),
},
- }), nil
+ })
+ if err != nil {
+ log.WithError(err).Errorf(c, "Failed to create BigTable instance.")
+ return nil, err
+ }
+ return st, nil
}
« no previous file with comments | « no previous file | appengine/logdog/coordinator/endpoints/logs/get.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698