Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() (Closed)

Created:
4 years, 9 months ago by Xianzhu
Modified:
4 years, 9 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@pi0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() They replace some original implementations of clippedOverflowRectForPaintInvalidation() and selectionRectForPaintInvalidation(), so that the implementations don't need to map to backing by themselves. BUG=591199 Committed: https://crrev.com/a17fa727d64fb2a5cd12269e033a3a903641eab5 Cr-Commit-Position: refs/heads/master@{#383345}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebase #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -111 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBR.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBR.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 2 chunks +13 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 chunks +22 lines, -9 lines 3 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 2 chunks +5 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +3 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 1813383002 Patch 300001

Messages

Total messages: 14 (5 generated)
Xianzhu
Separated from https://codereview.chromium.org/1813383002/. This is a simple part for which few comments were posted in ...
4 years, 9 months ago (2016-03-25 18:41:32 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp#newcode1641 third_party/WebKit/Source/core/layout/LayoutObject.cpp:1641: LayoutRect LayoutObject::clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const ...
4 years, 9 months ago (2016-03-25 20:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837533002/60001
4 years, 9 months ago (2016-03-25 20:20:33 UTC) #5
chrishtr
https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp#newcode1641 third_party/WebKit/Source/core/layout/LayoutObject.cpp:1641: LayoutRect LayoutObject::clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const On ...
4 years, 9 months ago (2016-03-25 20:21:08 UTC) #7
Xianzhu
https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1837533002/diff/60001/third_party/WebKit/Source/core/layout/LayoutObject.cpp#newcode1641 third_party/WebKit/Source/core/layout/LayoutObject.cpp:1641: LayoutRect LayoutObject::clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintInvalidationState) const On ...
4 years, 9 months ago (2016-03-25 20:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837533002/60001
4 years, 9 months ago (2016-03-25 20:28:35 UTC) #10
pdr.
On 2016/03/25 at 20:28:35, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 9 months ago (2016-03-25 20:31:31 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-25 20:34:45 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 20:36:19 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a17fa727d64fb2a5cd12269e033a3a903641eab5
Cr-Commit-Position: refs/heads/master@{#383345}

Powered by Google App Engine
This is Rietveld 408576698