third_party/WebKit/Source/core/layout/LayoutBR.cpp - Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBR.cpp

Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi0

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBR.h ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBR.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBR.cpp b/third_party/WebKit/Source/core/layout/LayoutBR.cpp

index 25ba1c9c3983370171a942119647bf5cffe35a1d..64c5dff5d14798cde936c3ac72299719a484118b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBR.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBR.cpp

@@ -43,13 +43,6 @@ LayoutBR::~LayoutBR()

{

}

-LayoutRect LayoutBR::selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const

- // Although line breaks contain no actual text, if we're selected we need

- // to return a rect that includes space to illustrate a newline.

- return LayoutText::selectionRectForPaintInvalidation(paintInvalidationContainer);

int LayoutBR::lineHeight(bool firstLine) const

{

const ComputedStyle& style = styleRef(firstLine && document().styleEngine().usesFirstLineRules());