third_party/WebKit/Source/core/layout/LayoutListMarker.h - Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.h

Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi0

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutInline.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutListMarker.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.h b/third_party/WebKit/Source/core/layout/LayoutListMarker.h

index ce0f09d630bfb4455890eb1464df6e6eed107812..98dc8056f1ebc1452a702d7852254457c409961e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.h

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.h

@@ -54,7 +54,7 @@ public:

void updateMarginsAndContent();

IntRect getRelativeMarkerRect() const;

- LayoutRect localSelectionRect() const;

+ LayoutRect localSelectionRect() const final;

bool isImage() const override;

const StyleImage* image() const { return m_image.get(); }

const LayoutListItem* listItem() const { return m_listItem; }

@@ -88,7 +88,6 @@ private:

bool isText() const { return !isImage(); }

void setSelectionState(SelectionState) override;

- LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const override;

bool canBeSelectionLeaf() const override { return true; }

LayoutUnit getWidthOfTextWithSuffix() const;