Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp

Issue 1837533002: LayoutObject::localOverflowRectForPaintInvalidation() and localSelectionRect() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi0
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 return child->isLayoutTableCol() && style.display() == TABLE_COLUMN; 101 return child->isLayoutTableCol() && style.display() == TABLE_COLUMN;
102 } 102 }
103 103
104 bool LayoutTableCol::canHaveChildren() const 104 bool LayoutTableCol::canHaveChildren() const
105 { 105 {
106 // Cols cannot have children. This is actually necessary to fix a bug 106 // Cols cannot have children. This is actually necessary to fix a bug
107 // with libraries.uc.edu, which makes a <p> be a table-column. 107 // with libraries.uc.edu, which makes a <p> be a table-column.
108 return isTableColumnGroup(); 108 return isTableColumnGroup();
109 } 109 }
110 110
111 LayoutRect LayoutTableCol::clippedOverflowRectForPaintInvalidation(const LayoutB oxModelObject* paintInvalidationContainer, const PaintInvalidationState* paintIn validationState) const 111 LayoutRect LayoutTableCol::localOverflowRectForPaintInvalidation() const
112 { 112 {
113 // Entire table gets invalidated, instead of invalidating 113 // Entire table gets invalidated, instead of invalidating
114 // every cell in the column. 114 // every cell in the column.
115 // This is simpler, but suboptimal. 115 // This is simpler, but suboptimal.
116 116
117 LayoutTable* table = this->table(); 117 LayoutTable* table = this->table();
118 if (!table) 118 if (!table)
119 return LayoutRect(); 119 return LayoutRect();
120 120
121 // The correctness of this method depends on the fact that LayoutTableCol's 121 // The correctness of this method depends on the fact that LayoutTableCol's
122 // location is always zero. 122 // location is always zero.
123 ASSERT(this->location() == LayoutPoint()); 123 ASSERT(this->location() == LayoutPoint());
124 124
125 LayoutRect r = table->visualOverflowRect(); 125 return table->localOverflowRectForPaintInvalidation();
126 mapToVisibleRectInAncestorSpace(paintInvalidationContainer, r, paintInvalida tionState);
127 return r;
128 } 126 }
129 127
130 void LayoutTableCol::imageChanged(WrappedImagePtr, const IntRect*) 128 void LayoutTableCol::imageChanged(WrappedImagePtr, const IntRect*)
131 { 129 {
132 // FIXME: Issue paint invalidation of only the rect the image paints in. 130 // FIXME: Issue paint invalidation of only the rect the image paints in.
133 setShouldDoFullPaintInvalidation(); 131 setShouldDoFullPaintInvalidation();
134 } 132 }
135 133
136 void LayoutTableCol::clearPreferredLogicalWidthsDirtyBits() 134 void LayoutTableCol::clearPreferredLogicalWidthsDirtyBits()
137 { 135 {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 return style()->borderStart(); 192 return style()->borderStart();
195 } 193 }
196 194
197 const BorderValue& LayoutTableCol::borderAdjoiningCellAfter(const LayoutTableCel l* cell) const 195 const BorderValue& LayoutTableCol::borderAdjoiningCellAfter(const LayoutTableCel l* cell) const
198 { 196 {
199 ASSERT_UNUSED(cell, table()->colElementAtAbsoluteColumn(cell->absoluteColumn Index() - 1).innermostColOrColGroup() == this); 197 ASSERT_UNUSED(cell, table()->colElementAtAbsoluteColumn(cell->absoluteColumn Index() - 1).innermostColOrColGroup() == this);
200 return style()->borderEnd(); 198 return style()->borderEnd();
201 } 199 }
202 200
203 } // namespace blink 201 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698