Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating. (Closed)

Created:
4 years, 8 months ago by pfeldman
Modified:
4 years, 8 months ago
Reviewers:
dominickn, dgozman, gone, sky
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating. TBR=sky Committed: https://crrev.com/5f0773a4f3a8e46a2093e04b06618be203cbfcbc Cr-Commit-Position: refs/heads/master@{#383745}

Patch Set 1 #

Patch Set 2 : android bots #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -74 lines) Patch
M chrome/browser/android/tab_web_contents_delegate_android.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/tab_web_contents_delegate_android.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/protocol/page_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/page_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ResourceType.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/front_end/components/RequestAppBannerActionDelegate.js View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/module.json View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeWrapper.js View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/module.json View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js View 2 chunks +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/module.json View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
pfeldman
4 years, 8 months ago (2016-03-28 18:36:16 UTC) #2
pfeldman
PTAL
4 years, 8 months ago (2016-03-28 23:45:10 UTC) #3
dgozman
devtools still lgtm
4 years, 8 months ago (2016-03-28 23:50:25 UTC) #4
dominickn
non-OWNER lgtm % trybots. +dfalcantara for chrome/browser/android
4 years, 8 months ago (2016-03-29 00:06:52 UTC) #6
gone
c/b/android lgtm
4 years, 8 months ago (2016-03-29 00:07:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836943002/1
4 years, 8 months ago (2016-03-29 00:10:09 UTC) #9
pfeldman
+sky for chrome/browser/ui review (I am renaming a public content method name).
4 years, 8 months ago (2016-03-29 00:12:28 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/41404)
4 years, 8 months ago (2016-03-29 00:27:25 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836943002/20001
4 years, 8 months ago (2016-03-29 00:46:05 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/41506)
4 years, 8 months ago (2016-03-29 01:02:36 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836943002/40001
4 years, 8 months ago (2016-03-29 01:43:19 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 05:43:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836943002/40001
4 years, 8 months ago (2016-03-29 16:50:46 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 16:56:42 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 16:58:01 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f0773a4f3a8e46a2093e04b06618be203cbfcbc
Cr-Commit-Position: refs/heads/master@{#383745}

Powered by Google App Engine
This is Rietveld 408576698