components/web_contents_delegate_android/web_contents_delegate_android.h - Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.h

Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_contents_delegate_android/web_contents_delegate_android.h

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.h b/components/web_contents_delegate_android/web_contents_delegate_android.h

index f2ed5d902a2077fe5344233a9a03d1a093a6c7b1..6bcc2b7f07993919e92a22932c0e5049ea91e6ac 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.h

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.h

@@ -112,7 +112,8 @@ class WebContentsDelegateAndroid : public content::WebContentsDelegate {

void HideValidationMessage(content::WebContents* web_contents) override;

void MoveValidationMessage(content::WebContents* web_contents,

const gfx::Rect& anchor_in_root_view) override;

- bool RequestAppBanner(content::WebContents* web_contents) override;

+ void RequestAppBannerFromDevTools(

+ content::WebContents* web_contents) override;

protected:

base::android::ScopedJavaLocalRef<jobject> GetJavaDelegate(JNIEnv* env) const;

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.cc » ('j') | no next file with comments »