Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: chrome/browser/android/tab_web_contents_delegate_android.cc

Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.h ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/tab_web_contents_delegate_android.cc
diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc
index 2298726ef3133f91d15673df9a32e760a9af52a0..eb913c3352a6c22c8eae5e70247f0a2e9ffb4c63 100644
--- a/chrome/browser/android/tab_web_contents_delegate_android.cc
+++ b/chrome/browser/android/tab_web_contents_delegate_android.cc
@@ -420,13 +420,13 @@ void TabWebContentsDelegateAndroid::AddNewContents(
delete new_contents;
}
-bool TabWebContentsDelegateAndroid::RequestAppBanner(
+void TabWebContentsDelegateAndroid::RequestAppBannerFromDevTools(
content::WebContents* web_contents) {
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);
if (obj.is_null())
- return false;
- return Java_TabWebContentsDelegateAndroid_requestAppBanner(env, obj.obj());
+ return;
+ Java_TabWebContentsDelegateAndroid_requestAppBanner(env, obj.obj());
}
} // namespace android
« no previous file with comments | « chrome/browser/android/tab_web_contents_delegate_android.h ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698