third_party/WebKit/Source/devtools/front_end/screencast/module.json - Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/screencast/module.json

Issue 1836943002: DevTools: request app banner from DevTools without #enable-add-to-shelf flag while emulating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js ('k') | third_party/WebKit/Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/screencast/module.json

diff --git a/third_party/WebKit/Source/devtools/front_end/screencast/module.json b/third_party/WebKit/Source/devtools/front_end/screencast/module.json

index 0f9edda2805965d2026cd436592c0109e570f585..64f46d99e7d71e198c15f01104cb93b0d495bd07 100644

--- a/third_party/WebKit/Source/devtools/front_end/screencast/module.json

+++ b/third_party/WebKit/Source/devtools/front_end/screencast/module.json

@@ -12,18 +12,11 @@

"location": "main-toolbar-left"

{

- "type": "@WebInspector.ActionDelegate",

- "actionId": "screencast.request-app-banner",

- "className": "WebInspector.ScreencastApp.ActionDelegate",

- "title": "Request app banner\u2026"

- },

- {

"type": "context-menu-item",

"condition": "remoteFrontend",

"location": "mainMenu/tools",

- "experiment": "appBanner",

"order": 10,

- "actionId": "screencast.request-app-banner"

+ "actionId": "components.request-app-banner"

}

"dependencies": [