Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1836243002: Reland of Use the crrev recipe module to fetch commit hashes. (Closed)

Created:
4 years, 8 months ago by qyearsley
Modified:
4 years, 8 months ago
Reviewers:
RobertoCN, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, prasadv
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Use the crrev recipe module to fetch commit hashes. (patchset #1 id:1 of https://codereview.chromium.org/1801843002/ ) Reason for revert: Relanding because the fix to crrev (https://codereview.chromium.org/1796993002/) has now landed. Original issue's description: > Revert of Use the crrev recipe module to fetch commit hashes. (patchset #2 id:20001 of https://codereview.chromium.org/1773933002/ ) > > Reason for revert: > Causing failures e.g.: > > https://build.chromium.org/p/tryserver.chromium.perf/builders/android_fyi_perf_bisect/builds/196 > > Original issue's description: > > Use the crrev recipe module to fetch commit hashes. > > > > BUG=585563 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299254 > > TBR=prasadv@chromium.org,robertocn@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=585563 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299274 TBR=prasadv@chromium.org,robertocn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299544

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+703 lines, -480 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/__init__.py View 1 1 chunk +8 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 1 chunk +7 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 1 1 chunk +6 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect.py View 1 1 chunk +6 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json View 1 1 chunk +32 lines, -22 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
qyearsley
Created Reland of Use the crrev recipe module to fetch commit hashes.
4 years, 8 months ago (2016-03-29 16:35:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836243002/1
4 years, 8 months ago (2016-03-29 16:35:17 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build Try Recipe Test Trusty64 on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20Test%20Trusty64/builds/513)
4 years, 8 months ago (2016-03-29 16:37:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836243002/1
4 years, 8 months ago (2016-03-29 17:11:39 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3382) Build ...
4 years, 8 months ago (2016-03-29 17:12:50 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836243002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836243002/280001
4 years, 8 months ago (2016-03-29 17:26:36 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 17:30:27 UTC) #12
qyearsley
On 2016/03/29 at 17:30:27, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 8 months ago (2016-03-29 17:34:27 UTC) #13
RobertoCN
lgtm
4 years, 8 months ago (2016-03-29 18:44:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836243002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836243002/280001
4 years, 8 months ago (2016-03-29 21:02:22 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:06:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:280001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299544

Powered by Google App Engine
This is Rietveld 408576698