Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: scripts/slave/recipes/bisect_test/example_bisect_results.py

Issue 1836243002: Reland of Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/bisect_test/example_bisect_results.py
diff --git a/scripts/slave/recipes/bisect_test/example_bisect_results.py b/scripts/slave/recipes/bisect_test/example_bisect_results.py
index 3be8ddca28bc9d36c9a97683ef828ab8e1fdff5a..2d82607a6b38b122af84b7260403bea41d3e47c8 100644
--- a/scripts/slave/recipes/bisect_test/example_bisect_results.py
+++ b/scripts/slave/recipes/bisect_test/example_bisect_results.py
@@ -91,9 +91,11 @@ def set_attributes(target, attributes):
def add_revision_mapping(api, test, pos, sha):
- step_name = 'Resolving reference range.resolving commit_pos ' + pos
- stdout = api.raw_io.output('hash:' + sha)
+ step_name = ('Resolving reference range.crrev get commit hash for ' +
+ 'refs/heads/master@{#%s}' % pos)
+ stdout = api.json.output({'git_sha': sha})
test += api.step_data(step_name, stdout=stdout)
+
step_name = 'Resolving reference range.resolving hash ' + sha
pos = 'refs/heads/master@{#%s}' % pos
stdout = api.raw_io.output(pos)

Powered by Google App Engine
This is Rietveld 408576698