Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: scripts/slave/recipes/bisect.expected/basic.json

Issue 1836243002: Reland of Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/bisect.py ('k') | scripts/slave/recipes/bisect.expected/basic_return_code_test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/bisect.expected/basic.json
diff --git a/scripts/slave/recipes/bisect.expected/basic.json b/scripts/slave/recipes/bisect.expected/basic.json
index 7f29d7e811f2226416a23053b5497f0d1c95c360..c4a0417c2de878984a1241b66b93c4ad117b97a6 100644
--- a/scripts/slave/recipes/bisect.expected/basic.json
+++ b/scripts/slave/recipes/bisect.expected/basic.json
@@ -213,36 +213,46 @@
},
{
"cmd": [
- "git",
- "log",
- "--format=hash:%H",
- "--grep",
- "^Cr-Commit-Position: refs/heads/master@{#306478}",
- "-1",
- "origin/master"
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::crrev]/resources/crrev_client.py",
+ "get_numbering",
+ "--params-file",
+ "{\"number\": 306478, \"numbering_identifier\": \"refs/heads/master\", \"numbering_type\": \"COMMIT_POSITION\", \"project\": \"chromium\", \"repo\": \"chromium/src\"}",
+ "--attempts",
+ "3"
],
- "cwd": "[SLAVE_BUILD]/src",
- "name": "Resolving reference range.resolving commit_pos 306478",
- "stdout": "/path/to/tmp/",
+ "cwd": "[SLAVE_BUILD]",
+ "name": "Resolving reference range.crrev get commit hash for refs/heads/master@{#306478}",
+ "stdout": "/path/to/tmp/json",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"git_sha\": \"a6298e4afedbf2cd461755ea6f45b0ad64222222\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
]
},
{
"cmd": [
- "git",
- "log",
- "--format=hash:%H",
- "--grep",
- "^Cr-Commit-Position: refs/heads/master@{#306475}",
- "-1",
- "origin/master"
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::crrev]/resources/crrev_client.py",
+ "get_numbering",
+ "--params-file",
+ "{\"number\": 306475, \"numbering_identifier\": \"refs/heads/master\", \"numbering_type\": \"COMMIT_POSITION\", \"project\": \"chromium\", \"repo\": \"chromium/src\"}",
+ "--attempts",
+ "3"
],
- "cwd": "[SLAVE_BUILD]/src",
- "name": "Resolving reference range.resolving commit_pos 306475",
- "stdout": "/path/to/tmp/",
+ "cwd": "[SLAVE_BUILD]",
+ "name": "Resolving reference range.crrev get commit hash for refs/heads/master@{#306475}",
+ "stdout": "/path/to/tmp/json",
"~followup_annotations": [
- "@@@STEP_NEST_LEVEL@1@@@"
+ "@@@STEP_NEST_LEVEL@1@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"git_sha\": \"e28dc0d49c331def2a3bbf3ddd0096eb51551155\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
]
},
{
« no previous file with comments | « scripts/slave/recipes/bisect.py ('k') | scripts/slave/recipes/bisect.expected/basic_return_code_test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698