Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1836243002: Reland of Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index 162d3ff4b32f6574fb2701fea7668d3dc4470ce2..d99307ad604d3b73ce566d95423e6242cc21578b 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -147,7 +147,13 @@ class Bisector(object):
if self._is_sha1(rev): # pragma: no cover
return rev
if rev.isdigit():
- return self._api.m.commit_position.chromium_hash_from_commit_position(rev)
+ commit_position = self._api.m.commit_position.construct(
+ branch='refs/heads/master', value=rev)
+ try:
+ return self._api.m.crrev.to_commit_hash(commit_position)
+ except self.api.m.step.StepFailure: # pragma: no cover
+ self.surface_result('BAD_REV')
+ raise
self.surface_result('BAD_REV') # pragma: no cover
raise self.api.m.step.StepFailure(
'Invalid input revision: %r' % (rev,)) # pragma: no cover
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/__init__.py ('k') | scripts/slave/recipe_modules/auto_bisect/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698