Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1836203002: Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/battery-status/api-defined.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/renderer_blink_platform_impl.cc
diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc
index 856241b8d4aa735cf4ff6c147acc0c11ce913c3a..4f722a4a35a3d3dc35d7374f30364f8eb1aecf4f 100644
--- a/content/renderer/renderer_blink_platform_impl.cc
+++ b/content/renderer/renderer_blink_platform_impl.cc
@@ -1168,14 +1168,6 @@ void RendererBlinkPlatformImpl::SetPlatformEventObserverForTesting(
void RendererBlinkPlatformImpl::connectToRemoteService(
const char* name,
mojo::ScopedMessagePipeHandle handle) {
- // In the layout test mode, mock services should be used instead.
- // TODO(yukishiino): We'd like to inject mock services implemented in
- // JavaScript. Remove the following hack once we support JS-bindings
- // of Mojo and service mocking in JS.
- if (RenderThreadImpl::current() &&
- RenderThreadImpl::current()->layout_test_mode())
- return;
-
RenderThread::Get()->GetServiceRegistry()->ConnectToRemoteService(
name, std::move(handle));
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/battery-status/api-defined.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698