third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html - Issue 1836203002: Change the battery-status layout tests to use JS mocks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

Issue 1836203002: Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js ('K') | « third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js ('k') | third_party/WebKit/LayoutTests/resources/mojo-helpers.js » ('j') | third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

	5 <script src="../resources/mojo-helpers.js"></script>

	6 <script src="resources/mock-battery-monitor.js"></script>

5 <script>	7 <script>

6 description("Test to ensure level is reported with restricted precision.");	8 description("Test to ensure level is reported with restricted precision.");

7	9

8 if (!window.testRunner)	10 if (!window.testRunner)

9 debug('This test cannot be run without the TestRunner');	11 debug('This test cannot be run without the TestRunner');

10 if (!window.internals)	12 if (!window.internals)

11 debug('This test cannot be run without the window.internals');	13 debug('This test cannot be run without the window.internals');

12	14

13 // Clean-up any unused battery manager objects from previous tests.	15 // Clean-up any unused battery manager objects from previous tests.

14 gc();	16 gc();

15 jsTestIsAsync = true;	17 jsTestIsAsync = true;

16 testRunner.waitUntilDone();	18 testRunner.waitUntilDone();

17	19

18 var levelFullPrecision = 0.556789;	20 var levelFullPrecision = 0.556789;

19 var levelRounded = 0.56;	21 var levelRounded = 0.56;

20	22

21 function setAndFireMockBatteryInfo(charging, chargingTime, dischargingTime, leve l) {

22 window.internals.updateBatteryStatus(charging, chargingTime, dischargingTime , level);

23 }

24

25 var battery;	23 var battery;
	Yuki 2016/03/30 02:39:46 We don't need this variable. Let's add \|let\| on l We don't need this variable. Let's add \|let\| on line 26, or just rename \|battery\| to \|battery\|manager\| in batteryStatusSuccess, or vice versa.
26 function batteryStatusSuccess(batteryManager) {	24 function batteryStatusSuccess(batteryManager) {

27 debug('batteryStatusSuccess invoked');	25 debug('batteryStatusSuccess invoked');

28 battery = batteryManager;	26 battery = batteryManager;

29 shouldBe('battery.level', 'levelRounded');	27 shouldBe('battery.level', 'levelRounded');

30 setTimeout(finishJSTest, 0);	28 setTimeout(finishJSTest, 0);

31 }	29 }

32	30

33 function batteryStatusFailure() {	31 ready.then(() => {

34 testFailed('failed to successfully resolve the promise');	32 navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

35 setTimeout(finishJSTest, 0);	33 setAndFireMockBatteryInfo(false, 10, 20, levelFullPrecision);

36 }	34 });

37

38 navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

39 setAndFireMockBatteryInfo(false, 10, 20, levelFullPrecision);

40 </script>	35 </script>

41 </body>	36 </body>

42 </html>	37 </html>

OLD	NEW