Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1834333002: Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate. On precompiled Space Blast on an iTouch 6, reduces finalizing the vm isolate from 60ms to <1 ms, but loading the isolate snapshot doesn't happen any sooner. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/e228e7826497ec16fa3f1d56e57fafe4f2de0294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M runtime/vm/heap.h View 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/heap.cc View 3 chunks +12 lines, -7 lines 0 comments Download
M runtime/vm/heap_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M runtime/vm/pages.h View 3 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/pages.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-03-29 17:19:27 UTC) #3
Florian Schneider
lgtm
4 years, 8 months ago (2016-03-29 17:47:57 UTC) #4
rmacnak
4 years, 8 months ago (2016-03-29 23:49:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e228e7826497ec16fa3f1d56e57fafe4f2de0294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698