runtime/vm/heap_test.cc - Issue 1834333002: Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/heap_test.cc

Issue 1834333002: Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/heap_test.cc

diff --git a/runtime/vm/heap_test.cc b/runtime/vm/heap_test.cc

index c76297d6d2b99a97e36fc7d88a49e701513580a6..bc914a43d7adeea4e445cfd704a1b25c8b9f31d8 100644

--- a/runtime/vm/heap_test.cc

+++ b/runtime/vm/heap_test.cc

@@ -284,9 +284,9 @@ TEST_CASE(IterateReadOnly) {

const String& obj = String::Handle(String::New("x", Heap::kOld));

Heap* heap = Thread::Current()->isolate()->heap();

EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));

- heap->WriteProtect(true, true /* include_code_pages */);

+ heap->WriteProtect(true);

EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));

- heap->WriteProtect(false, true /* include_code_pages */);

+ heap->WriteProtect(false);

EXPECT(heap->Contains(RawObject::ToAddr(obj.raw())));

}

« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »