Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: runtime/vm/heap.cc

Issue 1834333002: Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/heap_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.cc
diff --git a/runtime/vm/heap.cc b/runtime/vm/heap.cc
index 138e9b1e1902bb0e4d89fe983e6c3a46a6ac5d88..0cd9f41320f0c1e2bb8845e71f8f0f894af67c3d 100644
--- a/runtime/vm/heap.cc
+++ b/runtime/vm/heap.cc
@@ -260,6 +260,12 @@ void Heap::IterateOldObjects(ObjectVisitor* visitor) const {
}
+void Heap::IterateOldObjectsNoEmbedderPages(ObjectVisitor* visitor) const {
+ HeapIterationScope heap_iteration_scope;
+ old_space_.VisitObjectsNoEmbedderPages(visitor);
+}
+
+
void Heap::VisitObjectPointers(ObjectPointerVisitor* visitor) const {
new_space_.VisitObjectPointers(visitor);
old_space_.VisitObjectPointers(visitor);
@@ -511,10 +517,10 @@ bool Heap::GrowthControlState() {
}
-void Heap::WriteProtect(bool read_only, bool include_code_pages) {
+void Heap::WriteProtect(bool read_only) {
read_only_ = read_only;
new_space_.WriteProtect(read_only);
- old_space_.WriteProtect(read_only, include_code_pages);
+ old_space_.WriteProtect(read_only);
}
@@ -840,16 +846,15 @@ NoHeapGrowthControlScope::~NoHeapGrowthControlScope() {
}
-WritableVMIsolateScope::WritableVMIsolateScope(Thread* thread,
- bool include_code_pages)
- : StackResource(thread), include_code_pages_(include_code_pages) {
- Dart::vm_isolate()->heap()->WriteProtect(false, include_code_pages_);
+WritableVMIsolateScope::WritableVMIsolateScope(Thread* thread)
+ : StackResource(thread) {
+ Dart::vm_isolate()->heap()->WriteProtect(false);
}
WritableVMIsolateScope::~WritableVMIsolateScope() {
ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0);
- Dart::vm_isolate()->heap()->WriteProtect(true, include_code_pages_);
+ Dart::vm_isolate()->heap()->WriteProtect(true);
}
} // namespace dart
« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/heap_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698