Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: runtime/vm/pages.h

Issue 1834333002: Precompilation: Don't look at embedder allocated pages when finalizing the VM isolate. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.h
diff --git a/runtime/vm/pages.h b/runtime/vm/pages.h
index bd4ab5c5822340b37437b18da0e7784d98f1a592..ff1ca156544cbaaeadc8351b416a82ae0351aa09 100644
--- a/runtime/vm/pages.h
+++ b/runtime/vm/pages.h
@@ -52,6 +52,8 @@ class HeapPage {
return type_;
}
+ bool embedder_allocated() const { return memory_->embedder_allocated(); }
+
void VisitObjects(ObjectVisitor* visitor) const;
void VisitObjectPointers(ObjectPointerVisitor* visitor) const;
@@ -254,6 +256,7 @@ class PageSpace {
}
void VisitObjects(ObjectVisitor* visitor) const;
+ void VisitObjectsNoEmbedderPages(ObjectVisitor* visitor) const;
void VisitObjectPointers(ObjectPointerVisitor* visitor) const;
RawObject* FindObject(FindObjectVisitor* visitor,
@@ -292,7 +295,7 @@ class PageSpace {
// Note: Code pages are made executable/non-executable when 'read_only' is
// true/false, respectively.
- void WriteProtect(bool read_only, bool include_code_pages);
+ void WriteProtect(bool read_only);
void WriteProtectCode(bool read_only);
void AddGCTime(int64_t micros) {
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698