Make EnableViewSourceMode a FrameMsg

Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/91b7abf01349ef9ac154a97cceebfa88360506fe
Cr-Commit-Position: refs/heads/master@{#383062}

[clamy, 2016-03-24 13:28:05]

Description was changed from

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
==========

to

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-03-24 13:28:44]

Description was changed from

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2016-03-24 13:28:44]

clamy@chromium.org changed reviewers:
+ nasko@chromium.org

[clamy, 2016-03-24 13:29:18]

@nasko: PTAL. This is the split off CL for the EnableViewSourceMode IPC.

[nasko, 2016-03-24 13:55:23]

LGTM with a couple of nits.

https://codereview.chromium.org/1832803002/diff/1/content/common/frame_messag...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/1832803002/diff/1/content/common/frame_messag...
content/common/frame_messages.h:883: // only be sent the main frame.
nit: "sent to the main frame".

https://codereview.chromium.org/1832803002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1832803002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5098: if (!frame_)
nit: frame_ should never be invalid except for very narrow period during object
construction.

[clamy, 2016-03-24 14:01:36]

Thanks!

https://codereview.chromium.org/1832803002/diff/1/content/common/frame_messag...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/1832803002/diff/1/content/common/frame_messag...
content/common/frame_messages.h:883: // only be sent the main frame.
On 2016/03/24 13:55:23, nasko (slow) wrote:
> nit: "sent to the main frame".

Done.

https://codereview.chromium.org/1832803002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1832803002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:5098: if (!frame_)
On 2016/03/24 13:55:23, nasko (slow) wrote:
> nit: frame_ should never be invalid except for very narrow period during
object
> construction.

Switched to a DCHECK.

[clamy, 2016-03-24 14:01:42]

The CQ bit was checked by clamy@chromium.org

[clamy, 2016-03-24 14:01:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1832803002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-03-24 14:01:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1832803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1832803002/20001

[commit-bot: I haz the power, 2016-03-24 15:17:54]

Description was changed from

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-24 15:17:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 15:19:08]

Description was changed from

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Make EnableViewSourceMode a FrameMsg

This CL moves the EnableViewSourceMode from ViewMsgs to FrameMsgs. This is a
preparatory CL for https://codereview.chromium.org/1811913003/.

BUG=555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/91b7abf01349ef9ac154a97cceebfa88360506fe
Cr-Commit-Position: refs/heads/master@{#383062}
==========

[commit-bot: I haz the power, 2016-03-24 15:19:09]

Patchset 2 (id:??) landed as
https://crrev.com/91b7abf01349ef9ac154a97cceebfa88360506fe
Cr-Commit-Position: refs/heads/master@{#383062}