content/browser/frame_host/render_frame_host_manager.cc - Issue 1832803002: Make EnableViewSourceMode a FrameMsg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 1832803002: Make EnableViewSourceMode a FrameMsg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 01547b0840e7a2f7e724e2e6076339116b90a7f2..cf373fd3173cd66d5b8b0180819fcb15aa7c7e0e 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -2161,9 +2161,9 @@ RenderFrameHostImpl* RenderFrameHostManager::UpdateStateForNavigate(

// The renderer can exit view source mode when any error or cancellation

// happen. We must overwrite to recover the mode.

if (dest_is_view_source_mode) {

- render_frame_host_->render_view_host()->Send(

- new ViewMsg_EnableViewSourceMode(

- render_frame_host_->render_view_host()->GetRoutingID()));

+ DCHECK(!render_frame_host_->GetParent());

+ render_frame_host_->Send(

+ new FrameMsg_EnableViewSourceMode(render_frame_host_->GetRoutingID()));

}

return render_frame_host_.get();