Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1832803002: Make EnableViewSourceMode a FrameMsg (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 1081285e05fb8cd9436b5d9304b9d4976130ea10..810968476f3f852978f8fa8c8e3c5374170e8130 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3806,6 +3806,16 @@ void WebContentsImpl::RenderFrameCreated(RenderFrameHost* render_frame_host) {
observers_,
RenderFrameCreated(render_frame_host));
SetAccessibilityModeOnFrame(accessibility_mode_, render_frame_host);
+
+ if (!render_frame_host->IsRenderFrameLive() || render_frame_host->GetParent())
+ return;
+
+ NavigationEntry* entry = controller_.GetPendingEntry();
+ if (entry && entry->IsViewSourceMode()) {
+ // Put the renderer in view source mode.
+ render_frame_host->Send(
+ new FrameMsg_EnableViewSourceMode(render_frame_host->GetRoutingID()));
+ }
}
void WebContentsImpl::RenderFrameDeleted(RenderFrameHost* render_frame_host) {
@@ -3943,13 +3953,6 @@ void WebContentsImpl::RenderViewCreated(RenderViewHost* render_view_host) {
Source<WebContents>(this),
Details<RenderViewHost>(render_view_host));
- NavigationEntry* entry = controller_.GetPendingEntry();
- if (entry && entry->IsViewSourceMode()) {
- // Put the renderer in view source mode.
- render_view_host->Send(
- new ViewMsg_EnableViewSourceMode(render_view_host->GetRoutingID()));
- }
-
view_->RenderViewCreated(render_view_host);
FOR_EACH_OBSERVER(

Powered by Google App Engine
This is Rietveld 408576698