Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce isHTMLTableElement and toHTMLTableElement To avoid direct use of static_cast, this patch introduces isHTMLTableElement and toHTMLTableElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153897

Patch Set 1 #

Patch Set 2 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -37 lines) Patch
M Source/core/accessibility/AccessibilityTable.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.h View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/DOMUtilitiesPrivate.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/WebPageSerializer.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-10 13:23:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18313005/2001
7 years, 5 months ago (2013-07-10 13:27:05 UTC) #2
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 14:53:41 UTC) #3
Message was sent while issue was closed. 
Change committed as 153897

Powered by Google App Engine
This is Rietveld 408576698