Source/core/editing/markup.cpp - Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/markup.cpp

Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retry Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/markup.cpp

diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp

index 8d38db1fc4b430476a4a1ae0aef6a93ab5e16705..0328a3ed9de5f9657b8f58a653b6f6e52d52db30 100644

--- a/Source/core/editing/markup.cpp

+++ b/Source/core/editing/markup.cpp

@@ -51,6 +51,7 @@

#include "core/editing/htmlediting.h"

#include "core/html/HTMLBodyElement.h"

#include "core/html/HTMLElement.h"

+#include "core/html/HTMLTableElement.h"

#include "core/html/HTMLTextFormControlElement.h"

#include "core/page/Frame.h"

#include "core/rendering/RenderObject.h"

@@ -431,7 +432,7 @@ static Node* ancestorToRetainStructureAndAppearanceForBlock(Node* commonAncestor

if (commonAncestorBlock->hasTagName(tbodyTag) || commonAncestorBlock->hasTagName(trTag)) {

ContainerNode* table = commonAncestorBlock->parentNode();

- while (table && !table->hasTagName(tableTag))

+ while (table && !isHTMLTableElement(table))

table = table->parentNode();

return table;

« no previous file with comments | « Source/core/editing/htmlediting.cpp ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »