Source/core/html/HTMLFormElement.cpp - Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retry Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormElement.cpp

diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp

index e76d8d7bdcc5703f5dcfc578475251afa9639f3a..ce3447afc5c4c1675fb06d5c66dcbc679e4ab430 100644

--- a/Source/core/html/HTMLFormElement.cpp

+++ b/Source/core/html/HTMLFormElement.cpp

@@ -41,6 +41,7 @@

#include "core/html/HTMLCollection.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLInputElement.h"

+#include "core/html/HTMLTableElement.h"

#include "core/loader/FormState.h"

#include "core/loader/FrameLoader.h"

#include "core/loader/FrameLoaderClient.h"

@@ -104,7 +105,7 @@ bool HTMLFormElement::rendererIsNeeded(const NodeRenderingContext& context)

ContainerNode* node = parentNode();

RenderObject* parentRenderer = node->renderer();

// FIXME: Shouldn't we also check for table caption (see |formIsTablePart| below).

- bool parentIsTableElementPart = (parentRenderer->isTable() && node->hasTagName(tableTag))

+ bool parentIsTableElementPart = (parentRenderer->isTable() && isHTMLTableElement(node))

|| (parentRenderer->isTableRow() && node->hasTagName(trTag))

|| (parentRenderer->isTableSection() && node->hasTagName(tbodyTag))

|| (parentRenderer->isRenderTableCol() && node->hasTagName(colTag))

« no previous file with comments | « Source/core/editing/markup.cpp ('k') | Source/core/html/HTMLTableElement.h » ('j') | no next file with comments »