Source/web/DOMUtilitiesPrivate.cpp - Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/DOMUtilitiesPrivate.cpp

Issue 18313005: Introduce isHTMLTableElement and toHTMLTableElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retry Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/DOMUtilitiesPrivate.cpp

diff --git a/Source/web/DOMUtilitiesPrivate.cpp b/Source/web/DOMUtilitiesPrivate.cpp

index 2e8c3f4b7f17bf341e8dc3f0b92147496d6a4811..3c8c112417d018a4f588625d669fcd69c5c21c93 100644

--- a/Source/web/DOMUtilitiesPrivate.cpp

+++ b/Source/web/DOMUtilitiesPrivate.cpp

@@ -35,6 +35,7 @@

#include "core/dom/Element.h"

#include "core/html/HTMLAreaElement.h"

#include "core/html/HTMLInputElement.h"

+#include "core/html/HTMLTableElement.h"

using namespace WebCore;

using namespace WebCore::HTMLNames;

@@ -50,7 +51,7 @@ bool elementHasLegalLinkAttribute(const Element* element, const QualifiedName& a

if (attrName == actionAttr)

return element->hasTagName(formTag);

if (attrName == backgroundAttr)

- return element->hasTagName(bodyTag) || element->hasTagName(tableTag) || element->hasTagName(trTag) || element->hasTagName(tdTag);

+ return element->hasTagName(bodyTag) || isHTMLTableElement(element) || element->hasTagName(trTag) || element->hasTagName(tdTag);

if (attrName == citeAttr)

return element->hasTagName(blockquoteTag) || element->hasTagName(qTag) || element->hasTagName(delTag) || element->hasTagName(insTag);

if (attrName == classidAttr || attrName == dataAttr)

« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »