Require sRGB write control for sRGB support. Add flag to GrPaint to suppress linear -> sRGB convers…

Require sRGB write control for sRGB support. Add flag to GrPaint to suppress linear -> sRGB conversion on write. Use that to fix YUV conversion, which directly produces sRGB data. (Technically, it produces data in whatever the color space of the JPEG might be).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1830303002

Committed: https://skia.googlesource.com/skia/+/64d094d7756534a9b9b0997aab225d9ceba098b6

[Brian Osman, 2016-03-24 18:36:01]

Description was changed from

==========
Require sRGB write control for sRGB support. Add flag to GrPaint to suppress
linear -> sRGB conversion on write. Use that to fix YUV conversion, which
directly produces sRGB data. (Technically, it produces data in whatever the
color space of the JPEG might be).

BUG=skia:
==========

to

==========
Require sRGB write control for sRGB support. Add flag to GrPaint to suppress
linear -> sRGB conversion on write. Use that to fix YUV conversion, which
directly produces sRGB data. (Technically, it produces data in whatever the
color space of the JPEG might be).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-03-24 18:39:16]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, msarett@google.com, robertphillips@google.com

[Brian Osman, 2016-03-24 18:39:17]

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:2860: if (this->glCaps().srgbSupport()) {
Easy-to-miss: Had to promote this code out one scope to handle the case of
rendering to the same RT with different disableSRGB values.

[Brian Osman, 2016-03-24 18:39:22]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 18:39:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830303002/1

[commit-bot: I haz the power, 2016-03-24 18:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 18:55:23]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-03-25 01:29:54]

lgtm

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLCaps.h
File src/gpu/gl/GrGLCaps.h (left):

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLCaps.h#oldco...
src/gpu/gl/GrGLCaps.h:331: bool srgbWriteControl() const { return
fSRGBWriteControl; }
Perhaps we should update the comment on srgbSupport() to say that it means srgb
formats are supported and srgb reads of textures and srgb-blending to the render
target can both be optionally disabled when the render target has a srgb config.

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1830303002/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:2860: if (this->glCaps().srgbSupport()) {
On 2016/03/24 18:39:17, Brian Osman wrote:
> Easy-to-miss: Had to promote this code out one scope to handle the case of
> rendering to the same RT with different disableSRGB values.

right, nice catch.

[Brian Osman, 2016-03-25 12:48:16]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-03-25 12:48:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1830303002/#ps20001
(title: "Added comment to srgbSupport()")

[commit-bot: I haz the power, 2016-03-25 12:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830303002/20001

[commit-bot: I haz the power, 2016-03-25 13:02:02]

Description was changed from

==========
Require sRGB write control for sRGB support. Add flag to GrPaint to suppress
linear -> sRGB conversion on write. Use that to fix YUV conversion, which
directly produces sRGB data. (Technically, it produces data in whatever the
color space of the JPEG might be).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Require sRGB write control for sRGB support. Add flag to GrPaint to suppress
linear -> sRGB conversion on write. Use that to fix YUV conversion, which
directly produces sRGB data. (Technically, it produces data in whatever the
color space of the JPEG might be).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/64d094d7756534a9b9b0997aab225d9ceba098b6
==========

[commit-bot: I haz the power, 2016-03-25 13:02:03]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/64d094d7756534a9b9b0997aab225d9ceba098b6