Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 183003011: Revert 254567 "don't create SkDevice directly, use SkBitmap or (..." (Closed)

Created:
6 years, 9 months ago by Timur Iskhodzhanov
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 254567 "don't create SkDevice directly, use SkBitmap or (..." Valgrind has detected a few uninitialized memory reads after this change BUG=348905 > don't create SkDevice directly, use SkBitmap or (better) SkCanvas::NewRaster factory > > BUG=skia:2239 > TBR=scherkus@chromium.org > > Review URL: https://codereview.chromium.org/184743002 TBR=reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254714

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
6 years, 9 months ago (2014-03-04 08:07:49 UTC) #1
Timur Iskhodzhanov
6 years, 9 months ago (2014-03-04 08:14:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r254714.

Powered by Google App Engine
This is Rietveld 408576698